[PATCH] D66217: [BuildLibCalls] Noalias annotation

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 14 08:13:21 PDT 2019


jdoerfert added inline comments.


================
Comment at: lib/Transforms/Utils/BuildLibCalls.cpp:188
+    Changed |= setDoesNotAlias(F, 1);
+    LLVM_FALLTHROUGH;
   case LibFunc_strcat:
----------------
This makes sense.


================
Comment at: lib/Transforms/Utils/BuildLibCalls.cpp:263
     Changed |= setDoesNotCapture(F, 0);
+    Changed |= setDoesNotAlias(F, 0);
     Changed |= setDoesNotCapture(F, 1);
----------------
I'm not sure what this means or what this is going to help, but maybe I just miss something.


================
Comment at: lib/Transforms/Utils/BuildLibCalls.cpp:309
+    Changed |= setDoesNotAlias(F, 1);
+    LLVM_FALLTHROUGH;
   case LibFunc_memmove:
----------------
Makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66217/new/

https://reviews.llvm.org/D66217





More information about the llvm-commits mailing list