[PATCH] D66170: InferAddressSpaces: Move target intrinsic handling to TTI

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: include/llvm/Analysis/TargetTransformInfo.h:374
+  /// was handled.
+  bool rewriteIntrinsicWithAddressSpace(IntrinsicInst *II,
+                                        Value *OldV, Value *NewV) const;
----------------
hliao wrote:
> In general, we need to tell the value use, says save a generic pointer to somewhere, of a pointer from its address use. Only the later needs address-space resolving or inferring. It would be better to add the extra opnd index to help the target checks that case and only rewrite the address use.
InferAddressSpaces doesn't track this based on the operand index. This will expect any operands reported by collectRewritableIntrinsicOperands to be replaced, so it shouldn't be reporting any non-address uses


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66170/new/

https://reviews.llvm.org/D66170