[PATCH] D63547: [AIX]Global Address Lowering
Xiangling Liao via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 14 07:31:13 PDT 2019
Xiangling_L marked 3 inline comments as done.
Xiangling_L added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5076
+ const CodeModel::Model CModel = TM.getCodeModel();
+ assert((CModel != CodeModel::Tiny || CModel != CodeModel::Kernel) &&
+ "PowerPC doesn't support tiny or kernel code models.");
----------------
jasonliu wrote:
> hubert.reinterpretcast wrote:
> > Minor issue: This is currently `(!A || !B)`, but `!(A || B)` is meant.
> The landed commit did not address this comment. Could you do an NFC commit to address it?
Oops.... I addressed it but forgot to commit it together. Will do asap.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63547/new/
https://reviews.llvm.org/D63547
More information about the llvm-commits
mailing list