[PATCH] D65267: [MachineCopyPropagation] Remove redundant copies after TailDup via machine-cp

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 14 07:08:45 PDT 2019


jsji added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineCopyPropagation.cpp:303
+  }
+  if (!SrcMI || !Copy.getOperand(1).isKill())
+    return false;
----------------
Can we check `!Copy.getOperand(1).isKill()` earlier? before the backward `SrcMI` search? Maybe together with `isRenamable()`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65267/new/

https://reviews.llvm.org/D65267





More information about the llvm-commits mailing list