[PATCH] D64700: [SLPVectorizer] [NFC] Avoid repetitive calls to getSameOpcode().
Dinar Temirbulatov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 14 06:13:06 PDT 2019
dtemirbulatov marked an inline comment as done.
dtemirbulatov added inline comments.
================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:1572
const TreeEntry *getTreeEntry(Value *V) const {
- auto I = ScalarToTreeEntry.find(V);
- if (I != ScalarToTreeEntry.end())
- return VectorizableTree[I->second].get();
+ auto *I = dyn_cast<Instruction>(V);
+ auto It = ScalarToTreeEntry.find(I);
----------------
RKSimon wrote:
> vporpo wrote:
> > Same here
> These NFC changes are still here - remove from this patch?
hmm, We can refer to an entry by a pointer instead of a number and I prefer to keep it unless the other opinion?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64700/new/
https://reviews.llvm.org/D64700
More information about the llvm-commits
mailing list