[PATCH] D66207: [Attributor] Add CallSiteArgument and Argument AbstractAttribute for noalias

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 added a comment.

Minor comments



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1358
+  // Callback function
+  std::function<bool(CallSite)> CallSiteCheck = [&](CallSite CS) {
+    assert(CS && "Sanity check: Call site was not initialized properly!");
----------------
this can now be `auto CallSiteCheck = [&](CallSiteCheck CS){ ... }`
In D66155 I changed checkForAllCallSites to also use llvm::function_ref


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1375
+  };
+  if (!A.checkForAllCallSites(CallSiteCheck, *this, true))
+    return indicatePessimisticFixpoint();
----------------
It looks like this is not the latest version of checkForAllCallSites. Now it also takes a function as a parameter.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66207/new/

https://reviews.llvm.org/D66207