[PATCH] D66190: [CodeGen] Add a pass to do block predication on SSA machine IR

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

One more question - i can't recall if there's precedent for bundling more than one pass
into the same source file, that does not look ideal.

Can the pass not be run standalone, does it really require some specific target?
Perhaps that can be short-circuited via some `cl::opt` just for testing purposes?

I'm not sure it's a great idea to add dead code with no upstream test coverage.
At best, it will silently regress, at worst it can simply be dropped as dead code.



================
Comment at: llvm/lib/CodeGen/EarlyIfConversion.cpp:930-932
+//===----------------------------------------------------------------------===//
+//                           EarlyIfPredicator Pass
+//===----------------------------------------------------------------------===//
----------------
I'd think you want to not jam it next to existing pass, but put it into it's own place


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66190/new/

https://reviews.llvm.org/D66190