[PATCH] D66097: Handle local commons for XCOFF object file writing

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:238
+      assert(XCOFF::XTY_CM == MCSec->getCSectType() &&
+             "Mapping invalid csect. Csect with bss storage class must be "
+             "common type.");
----------------
"CSect" would match how the function is named.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-lcomm.ll:5
+; RUN: llc -mtriple powerpc-ibm-aix-xcoff -filetype=obj -o %t.o < %s
+; RUN: llvm-readobj --section-headers --file-header %t.o | \
+; RUN: FileCheck --check-prefix=OBJ %s
----------------
There should be a follow-up patch to this (dependent on D65240) that checks the symbol table entries.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-lcomm.ll:15
 ; CHECK-NEXT: .lcomm c,2,c,1
+; XCOFF64: LLVM ERROR: 64-bit XCOFF object files are not supported yet.
+
----------------
There is no matching RUN line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66097/new/

https://reviews.llvm.org/D66097