[PATCH] D66149: [BinaryFormat] Teach identify_magic about Tapi files.

[Juergen Ributzka via Phabricator via llvm-commits]

ributzka added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/Magic.h:52
     pdb,                 ///< Windows PDB debug info file
+    tapi_file,           ///< Text-based Dynamic Library Stub file
   };
----------------
cishida wrote:
> steven_wu wrote:
> > tapi_file is not very clear what it actually refer to. Maybe something like tapi_dylib_stub (I am not very happy with this as well)?
> what about tbd_file? or tapi_tbd_file? that way it can be deduced that tbd is short for the comment provided and would match the file extension?
I didn't use TBD file on purpose, because that is the current file extension. The file type is tapi and there might be other tapi files in the future that will have different file extensions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66149/new/

https://reviews.llvm.org/D66149