[PATCH] D66188: Remove minimum toolchain soft-error

[JF Bastien via Phabricator via llvm-commits]

jfb created this revision.
Herald added subscribers: llvm-commits, dexonsmith, jkorous, mgorny.
Herald added a project: LLVM.
jfb edited the summary of this revision.
jfb added subscribers: jyknight, lhames.

Back in January I changed the minimum toolchain version required to build clang and LLVM: D57264 <https://reviews.llvm.org/D57264>. Since then we've release LLVM 8, following our process <http://llvm.org/docs/DeveloperPolicy.html#toolchain> it's therefore now a good time to remove the soft-error and officially deprecate older toolchains. I tried this out last Tursday night to see if any bots complained, and I saw no complaints. I also manually audited bots and didn't see any bot that should break, but their toolchain information is unreliable and some bots are offline.

Once this patch stick we'll move to C++14 as we've already agreed <http://lists.llvm.org/pipermail/llvm-dev/2019-January/129452.html>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D66188

Files:
  llvm/cmake/modules/CheckCompilerVersion.cmake
  llvm/docs/GettingStarted.rst


Index: llvm/docs/GettingStarted.rst
===================================================================
--- llvm/docs/GettingStarted.rst
+++ llvm/docs/GettingStarted.rst
@@ -235,15 +235,6 @@
 * GCC 5.1
 * Visual Studio 2017
 
-The below versions currently soft-error as we transition to the new compiler
-versions listed above. The LLVM codebase is currently known to compile correctly
-with the following compilers, though this will change in the near future:
-
-* Clang 3.1
-* Apple Clang 3.1
-* GCC 4.8
-* Visual Studio 2017
-
 Anything older than these toolchains *may* work, but will require forcing the
 build system with a special option and is not really a supported host platform.
 Also note that older versions of these compilers have often crashed or
Index: llvm/cmake/modules/CheckCompilerVersion.cmake
===================================================================
--- llvm/cmake/modules/CheckCompilerVersion.cmake
+++ llvm/cmake/modules/CheckCompilerVersion.cmake
@@ -4,11 +4,11 @@
 
 include(CheckCXXSourceCompiles)
 
-set(GCC_MIN 4.8)
+set(GCC_MIN 5.1)
 set(GCC_SOFT_ERROR 5.1)
-set(CLANG_MIN 3.1)
+set(CLANG_MIN 3.5)
 set(CLANG_SOFT_ERROR 3.5)
-set(APPLECLANG_MIN 3.1)
+set(APPLECLANG_MIN 6.0)
 set(APPLECLANG_SOFT_ERROR 6.0)
 
 # https://en.wikipedia.org/wiki/Microsoft_Visual_C#Internal_version_numbering
@@ -17,7 +17,7 @@
 set(MSVC_SOFT_ERROR 19.1)
 
 # Map the above GCC versions to dates: https://gcc.gnu.org/develop.html#timeline
-set(GCC_MIN_DATE 20130322)
+set(GCC_MIN_DATE 20150422)
 set(GCC_SOFT_ERROR_DATE 20150422)
 
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66188.214980.patch
Type: text/x-patch
Size: 1553 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190813/1354616f/attachment.bin>