[PATCH] D66185: [AArch64][GlobalISel] Legalize 128 bit divisions to libcalls

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp:2959-2960
   (void)WideTy;
-  assert(WideTy.isVector() && "can only unmerge from vector types!");
+  assert(WideTy.isVector() ||
+         WideTy == LLT::scalar(128) && "can only unmerge from vector types!");
   assert(WideTy.getSizeInBits() > NarrowTy.getSizeInBits() &&
----------------
I think that you need braces around the `WideTy.isVector() || WideTy == LLT::Scalar(128)` here, because && has higher precedence than ||.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66185/new/

https://reviews.llvm.org/D66185