[PATCH] D66013: [X86] Emit correct unwind info for split-stack prologue

[Wei Mi via Phabricator via llvm-commits]

wmi added a comment.

I see. You already take the adjustment in insertCFIInstrs into consideration and assume the CFIs in the layout order will match CFIs in control flow in the end. In this way, .cfi_remember_state at the beginning of current BB is always assumed to remember the outgoing CFI information of its predecessor BB.

So the CFI sequence is correct but may not be optimal -- if .cfi_remember_state is inserted before the adjustment from insertCFIInstrs, nextMBB doesn't need the .cfi_def_cfa right?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66013/new/

https://reviews.llvm.org/D66013