[PATCH] D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value

Erik Pilkington via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 13 14:41:27 PDT 2019


erik.pilkington commandeered this revision.
erik.pilkington added a reviewer: arphaman.
erik.pilkington added a comment.
Herald added subscribers: dexonsmith, jkorous.
Herald added a project: LLVM.

Stealing this (with Alex's permission). I think it makes more sense to add a special case for the method -[NSBundle localizedStringForKey:value:table:] rather then add a new general purpose attribute that'll only be used in one place.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D27165/new/

https://reviews.llvm.org/D27165





More information about the llvm-commits mailing list