[PATCH] D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files.
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 13 14:38:07 PDT 2019
hubert.reinterpretcast added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1670
- // Create the symbol and emit it.
+ // Create the symbol, set its storage class and emit it.
MCSymbolXCOFF *XSym = cast<MCSymbolXCOFF>(getSymbol(GV));
----------------
Comma before the "and".
================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1673
+ XSym->setStorageClass(
+ TargetLoweringObjectFileXCOFF::getStorageClassForGlobal(GV));
const DataLayout &DL = GV->getParent()->getDataLayout();
----------------
Use `clang-format`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65159/new/
https://reviews.llvm.org/D65159
More information about the llvm-commits
mailing list