[PATCH] D66147: [TextAPI] Update reader to be supported by lib/Object

Juergen Ributzka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 13 14:01:38 PDT 2019


ributzka added inline comments.


================
Comment at: llvm/lib/TextAPI/MachO/TextStub.cpp:638
 
+  auto File = std::unique_ptr<InterfaceFile>(
+      const_cast<InterfaceFile *>(Files.front()));
----------------
Why did this move? Won't that leak the memory in the error case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66147/new/

https://reviews.llvm.org/D66147





More information about the llvm-commits mailing list