[PATCH] D66150: GlobalISel: Don't create G_UADDE with constant false carry in

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 13 10:26:39 PDT 2019


arsenm created this revision.
arsenm added reviewers: aemerson, aditya_nandakumar, paquette, igorb, aivchenk, craig.topper.
Herald added subscribers: Petar.Avramovic, volkan, atanasyan, javed.absar, rovka, nhaehnle, wdng, jvesely, sdardis.

I'm not sure what to do about the x86 test failures. The x86 tests are now broken (in paticular add-scalar.ll now hits the
DAG fallback) due to not handling G_UADDO. The DAG x86 backend has a
custom lowering for this, so that will need to be implemented.


https://reviews.llvm.org/D66150

Files:
  lib/CodeGen/GlobalISel/LegalizerHelper.cpp
  test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll
  test/CodeGen/AArch64/GlobalISel/legalize-add.mir
  test/CodeGen/AMDGPU/GlobalISel/legalize-add.mir
  test/CodeGen/AMDGPU/GlobalISel/legalize-phi.mir
  test/CodeGen/AMDGPU/GlobalISel/legalize-sitofp.mir
  test/CodeGen/Mips/GlobalISel/legalizer/add.mir
  test/CodeGen/Mips/GlobalISel/llvm-ir/add.ll
  test/CodeGen/X86/GlobalISel/add-scalar.ll
  test/CodeGen/X86/GlobalISel/legalize-add.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66150.214869.patch
Type: text/x-patch
Size: 32959 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190813/807c8a62/attachment.bin>


More information about the llvm-commits mailing list