[PATCH] D65189: [MC] Support returning a structured rich disassembly output

Tue Aug 13 07:36:20 PDT 2019

jhenderson accepted this revision.
jhenderson added a comment.

In D65189#1626565 <https://reviews.llvm.org/D65189#1626565>, @seiya wrote:

> In D65189#1625303 <https://reviews.llvm.org/D65189#1625303>, @jhenderson wrote:
>
> > You should update your patch title and description too.
>
>
> What do you think what the patch title should describe?
>
> How about  //"[MC] Support returning marked up ranges in the disassembly"// or //"[MCInstPrinter] Add MarkupStart/MarkupEnd/WithMarkup//?

I think the first of your suggestions is good.

Nit: "This feature will be used for the highlighting feature in llvm-objdump." should be "This feature will be used for a disassembly highlighting feature in llvm-objdump."

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65189/new/

https://reviews.llvm.org/D65189