[PATCH] D65189: [MC] Support returning a structured rich disassembly output

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added inline comments.


================
Comment at: llvm/include/llvm/MC/MCInstPrinter.h:64
+  /// InnerSpans contains one MarkupSpan which represents `<reg:%rip>`.
+  std::vector<MarkupSpan> InnerSpans;
+
----------------
Can you include an example where you might have two InnerSpans?


================
Comment at: llvm/include/llvm/MC/MCInstPrinter.h:80
+  bool Enabled;
+  std::stack<std::vector<MarkupSpan> *> &Spans;
+  MarkupType Type;
----------------
When do you need to have multiple Spans on the stack?
Can you add test coverage for that case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65189/new/

https://reviews.llvm.org/D65189