[PATCH] D66109: GlobalISel: Change representation of shuffle masks

Tue Aug 13 08:37:37 PDT 2019

arsenm added a comment.

In D66109#1627112 <https://reviews.llvm.org/D66109#1627112>, @aditya_nandakumar wrote:

> In D66109#1626195 <https://reviews.llvm.org/D66109#1626195>, @arsenm wrote:
>
> > In D66109#1626112 <https://reviews.llvm.org/D66109#1626112>, @aditya_nandakumar wrote:
> >
> > > Thanks for doing this. Overall the patch LGTM. On a side note, should we try to document all the links we have to IR in GlobalISel somewhere?
> >
> >
> > Not sure where that would go
>
>
> Perhaps in the bottom of https://www.llvm.org/docs/GlobalISel.html ? Alternatively we can document in GenericOpcodes.td right along the instructions which have links.

I added a note to GenericOpcodes.td

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66109/new/

https://reviews.llvm.org/D66109