[PATCH] D63459: Loop Cache Analysis

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D63459#1626024 <https://reviews.llvm.org/D63459#1626024>, @etiotto wrote:

> In D63459#1625843 <https://reviews.llvm.org/D63459#1625843>, @xbolva00 wrote:
>
> > /home/xbolva00/LLVM/llvm/lib/Analysis/LoopCacheAnalysis.cpp:110:14: warning: ‘llvm::raw_ostream& llvm::operator<<(llvm::raw_ostream&, const llvm::IndexedReference&)’ has not been declared within llvm
> >
> >   raw_ostream &llvm::operator<<(raw_ostream &OS, const IndexedReference &R) {
> >                ^~~~
> >
> > In file included from /home/xbolva00/LLVM/llvm/lib/Analysis/LoopCacheAnalysis.cpp:28:0:
> >  /home/xbolva00/LLVM/llvm/include/llvm/Analysis/LoopCacheAnalysis.h:45:23: note: only here as a friend
> >
> >   friend raw_ostream &operator<<(raw_ostream &OS, const IndexedReference &R);
> >                       ^~~~~~~~
> >
> > /home/xbolva00/LLVM/llvm/lib/Analysis/LoopCacheAnalysis.cpp:443:14: warning: ‘llvm::raw_ostream& llvm::operator<<(llvm::raw_ostream&, const llvm::CacheCost&)’ has not been declared within llvm
> >
> >   raw_ostream &llvm::operator<<(raw_ostream &OS, const CacheCost &CC) {
> >                ^~~~
> >
> > In file included from /home/xbolva00/LLVM/llvm/lib/Analysis/LoopCacheAnalysis.cpp:28:0:
> >  /home/xbolva00/LLVM/llvm/include/llvm/Analysis/LoopCacheAnalysis.h:174:23: note: only here as a friend
> >
> >   friend raw_ostream &operator<<(raw_ostream &OS, const CacheCost &CC);
> >   
> >   
> >
> > GCC 7 Linux.
>
>
> I uploaded a fix for this warning. I use clang to build sigh, apologies for the problem.


If the patch has not been reverted, I think it would be better to create a new patch on Phabricator with the fix, so it is easier to see the change.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63459/new/

https://reviews.llvm.org/D63459