[PATCH] D66101: gn build: Give cmake sync script an opt-in --write flag

[Nico Weber via Phabricator via llvm-commits]

thakis marked an inline comment as done.
thakis added a comment.

Thanks!



================
Comment at: llvm/utils/gn/build/sync_source_lists_from_cmake.py:34
+    if tokloc == -1: raise ValueError(gn_file + ': Failed to find source list')
+    if gn_contents.find(srcs_tok, tokloc + 1) != -1:
+        raise ValueError(gn_file + ': Multiple source lists')
----------------
pcc wrote:
> Should this also refuse to operate if it sees a `# NOSORT` comment? I think the only instance of that is in `clang/lib/Headers`, though -- maybe we can remove that comment now that we have a mechanism for automatic updates?
Good point. Made this balk on NOSORT for now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66101/new/

https://reviews.llvm.org/D66101