[PATCH] D65832: [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 13 02:13:07 PDT 2019


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM. Please wait for other opinion(s) too.



================
Comment at: llvm/test/tools/llvm-readobj/note-core-ntfile-bad.test:30
+  Type:          ET_CORE
+  Machine:       EM_X86_64
+Sections:
----------------
Please align:

>   Class:   ELFCLASS64
>   Data:    ELFDATA2LSB
>   Type:    ET_CORE
>   Machine: EM_X86_64




================
Comment at: llvm/test/tools/llvm-readobj/note-core-ntfile-bad.test:34
+    Type:        SHT_NOTE
+    Content: 0500000008000000454C4946434F5245000000000000000000000000
+ProgramHeaders:
----------------
and here (and below).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65832/new/

https://reviews.llvm.org/D65832





More information about the llvm-commits mailing list