[PATCH] D65765: [InstCombine] Non-canonical clamp-like pattern handling

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 23:09:58 PDT 2019


lebedev.ri added a comment.

In D65765#1625899 <https://reviews.llvm.org/D65765#1625899>, @spatel wrote:

> In D65765#1625870 <https://reviews.llvm.org/D65765#1625870>, @lebedev.ri wrote:
>
> > Thanks for taking a look.
> >
> > I'm not sure how to test `uge`/`sge` predicates - i can't come up with any pattern that still contains them after `-instcombine`.
> >  https://godbolt.org/z/7EAcfy
> >  I'm not sure if that is guaranteed (and thus i should just drop that handling), or i'm simply failing at test-case production.
>
>
> Non-splat vector constant + multiple-uses? :)
>  https://godbolt.org/z/6vuO14


Right, thanks!.
But that `icmp` *must* be single-use for this transform to happen. So sadly that does not help `uge` question.
That will help `sge` though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65765/new/

https://reviews.llvm.org/D65765





More information about the llvm-commits mailing list