[PATCH] D66075: [llvm-readobj][MachO] Fix section type printing

Mon Aug 12 20:30:22 PDT 2019

seiya added a comment.

Thank you for pointing out the related commits, @rupprecht!

In D66075#1625297 <https://reviews.llvm.org/D66075#1625297>, @jhenderson wrote:

> The change looks fine to me, although I wasn't able to quickly find the list of section types anywhere to check against. Could you provide me some documentation?

A list of section types in mach-o/loader.h (in Apple's binary utilities) <https://github.com/opensource-apple/cctools/blob/fdb4825f303fd5c0751be524babd32958181b3ed/include/mach-o/loader.h#L447-L505> or llvm/Binary/Format/MachO.h <https://github.com/llvm/llvm-project/blob/da1dfecd32f405d00b2432acd9fdd24526e5614f/llvm/include/llvm/BinaryFormat/MachO.h#L112-L173> might be helpful.

> Also, are there test cases for each of the different permitted types?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66075/new/

https://reviews.llvm.org/D66075