[PATCH] D65984: [GlobalISel] Make the InstructionSelector instance non-const, allowing state to be maintained.

[Amara Emerson via Phabricator via llvm-commits]

aemerson marked an inline comment as done.
aemerson added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/InstructionSelect.cpp:72
   assert(ISel && "Cannot work without InstructionSelector");
+  ISel->init(MF, CoverageInfo);
 
----------------
dsanders wrote:
> Just a nit pick: init() gives the impression that it will only be run once per object. Could we name it runBeforeISel(), prepareForMF() or something to make it clear that it runs every time?
setupForMF()?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65984/new/

https://reviews.llvm.org/D65984