[PATCH] D65914: [Dwarf] DW_TAG_unspecified_type is a type tag.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/Dwarf.h:118
   case DW_TAG_union_type:
-  case DW_TAG_ptr_to_member_type:
-  case DW_TAG_set_type:
-  case DW_TAG_subrange_type:
-  case DW_TAG_base_type:
-  case DW_TAG_const_type:
-  case DW_TAG_file_type:
-  case DW_TAG_packed_type:
+  case DW_TAG_unspecified_type:
   case DW_TAG_volatile_type:
----------------
aprantl wrote:
> Looking at the LHS, I think that the list was *meant* to be sorted by encoding value (cf. Table 7.3) which could make it easier to check whether some new group of TAGs have been added. I'm fine either way... Alphabetical also has its advantages.
The *nicest* way to implement this might be to add a new IS_TYPE field to the TAG macro in Dwarf.def and then generate this switch statement.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65914/new/

https://reviews.llvm.org/D65914