[PATCH] D66114: [ConstantHoisting] Fix non-determinism.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

The keys are subclasses of llvm::Value, so sorting is hard. There's no obvious comparator to sort global variables.  Instructions and basic blocks could be sorted based on DFS numbers, or something like that, but it would be a lot more complicated.

Looking again, a couple of these might not actually need to be ordered; in particular, BBs, and ConstCandMap.  I'll spend a bit more time to try and verify that.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66114/new/

https://reviews.llvm.org/D66114