[PATCH] D66111: GlobalISel: Implement lower for G_SHUFFLE_VECTOR

[Aditya Nandakumar via Phabricator via llvm-commits]

aditya_nandakumar accepted this revision.
aditya_nandakumar added a comment.
This revision is now accepted and ready to land.

LGTM - conditional to the parent patch.



================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:3774
+  auto MIB = MIRBuilder.buildInstrNoInsert(TargetOpcode::G_BUILD_VECTOR)
+    .addDef(DstReg);
+
----------------
Would it be possible to buildInstr in a way that it can be CSE'd (collect the regs in a SmallVector and build in the end)?
While I think the chances of CSEing a G_BUILD_VECTOR is quite low, it probably doesn't hurt to enable it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66111/new/

https://reviews.llvm.org/D66111