[PATCH] D66041: [TextAPI] Fix & Add tests for tbd files version 3.

Cyndy Ishida via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 15:29:38 PDT 2019


cishida marked an inline comment as done.
cishida added a comment.

I currently don't have commit access rights to push this patch. Can you commit this change for me while I request access?



================
Comment at: llvm/unittests/TextAPI/TextStubV3Tests.cpp:133
+// Disable test for windows.
+#ifndef _WIN32
+TEST(TBDv3, WriteFile) {
----------------
cishida wrote:
> ributzka wrote:
> > I think this test should work now on windows,
> Would removing that macro from all the text stub tests and running them be enough to verify it works on windows? 
resolved with  r357759


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66041/new/

https://reviews.llvm.org/D66041





More information about the llvm-commits mailing list