[PATCH] D63547: [AIX]Global Address Lowering
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 12 15:25:48 PDT 2019
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
LGTM with a minor issue that can be fixed on check-in.
================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5076
+ const CodeModel::Model CModel = TM.getCodeModel();
+ assert((CModel != CodeModel::Tiny || CModel != CodeModel::Kernel) &&
+ "PowerPC doesn't support tiny or kernel code models.");
----------------
Minor issue: This is currently `(!A || !B)`, but `!(A || B)` is meant.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63547/new/
https://reviews.llvm.org/D63547
More information about the llvm-commits
mailing list