[PATCH] D65573: Add User docs for ASTImporter

Aleksei Sidorin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 14:09:27 PDT 2019


a_sidorin added a comment.

That's incredible. Thank you!



================
Comment at: cfe/trunk/docs/LibASTImporter.rst:215
+    Node *Result =
+        const_cast<Node *>(MatchRes[0].template getNodeAs<Node>("bindStr"));
+    assert(Result);
----------------
We can avoid const_cast if we change the example function signature to `const Node *`.


================
Comment at: cfe/trunk/docs/LibASTImporter.rst:258
+
+We may extend the ``CmakeLists.txt`` under let's say ``clang/tools`` with the build and link instructions:
+
----------------
CMakeLists.txt


================
Comment at: cfe/trunk/docs/LibASTImporter.rst:557
+
+Now, Let's create an object file from the merged AST:
+
----------------
let's (small letter).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65573/new/

https://reviews.llvm.org/D65573





More information about the llvm-commits mailing list