[PATCH] D66024: Name Demangling as specified in the Vector Function ABI

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Analysis/SearchVectorFunctionSystem.h:29
+namespace llvm {
+
+/// Describes the type of Parameters
----------------
aranisumedh wrote:
> lebedev.ri wrote:
> > All these are currently in llvm namespace, would it be better to narrow it and put them into `VFABI`?
> Someone correct me if I am wrong. 
> 
> This module is intended to be extensible to other vectorization as well (as stated in the RFC). I am assuming that it can be extended to other ParameterKind as well. 
> 
> Whereas the name demangling for now is as stated in the vector function ABI and hence a part of the VFABI namespace.
I'm with @lebedev.ri, `ParameterKind` and `ParamType` are such generic names that one can easily see errors in the future of someone "seeing" that definition but not the intended one. What is the problem with wrapping this in the VFABI namespace even if we use it in other contexts?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66024/new/

https://reviews.llvm.org/D66024