[PATCH] D66047: Do not call replaceAllUsesWith to upgrade calls to ARC runtime functions to intrinsic calls

[Steven Wu via Phabricator via llvm-commits]

steven_wu accepted this revision.
steven_wu added inline comments.


================
Comment at: llvm/lib/IR/AutoUpgrade.cpp:3857
 
 void llvm::UpgradeARCRuntimeCalls(Module &M) {
+  // This lambda converts normal function calls to ARC runtime functions to
----------------
ahatanak wrote:
> steven_wu wrote:
> > I probably missed this from previous commit, shouldn't this function return `bool`?
> I changed the return type to void in a follow-up commit since nothing seemed to be using the return value. Do these functions have to return anything?
I guess it is just the convention and the return value is not used anymore. This is fine.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66047/new/

https://reviews.llvm.org/D66047