[PATCH] D66075: [llvm-readobj][MachO] Fix section type printing

Mon Aug 12 12:06:58 PDT 2019

rupprecht added a comment.

In D66075#1625297 <https://reviews.llvm.org/D66075#1625297>, @jhenderson wrote:

> The change looks fine to me, although I wasn't able to quickly find the list of section types anywhere to check against. Could you provide me some documentation?

This was already committed to LLVM years ago in rL178679 <https://reviews.llvm.org/rL178679> (+echristo, the committer), but mistakenly removed in rL235863 <https://reviews.llvm.org/rL235863> due to being an unused variable, instead of the right fix, which is clearly the Attributes->Types typo fixed here

Still, I can't find a reference for the original list, it would be good to cite one.

> Also, are there test cases for each of the different permitted types?

+1, would be nice to have a test in llvm-readobj that enumerates all section types in a yaml2obj case

(otherwise, LGTM)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66075/new/

https://reviews.llvm.org/D66075