[PATCH] D66084: Remove asserts in getLoopGuardBranch

Whitney Tsang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 11:31:53 PDT 2019


Whitney added inline comments.


================
Comment at: lib/Analysis/LoopInfo.cpp:364
+    return nullptr;
   BasicBlock *Preheader = getLoopPreheader();
   BasicBlock *Latch = getLoopLatch();
----------------
[style] new line after return statement.


================
Comment at: lib/Analysis/LoopInfo.cpp:369
+  // and loop should be in rotate form.
+  if (!Preheader || !Latch || !isLoopExiting(Latch))
+    return nullptr;
----------------
https://reviews.llvm.org/D65958 Add isRotated method to Loop class. Would be nice to use that instead. (but that is not landed yet)

[style] Upper case to start a new sentence, or change the period to a comma after `latch`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66084/new/

https://reviews.llvm.org/D66084





More information about the llvm-commits mailing list