[PATCH] D65751: [LNT] Add support for v2 fmt in test data library

Chris Matthews via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 10:58:19 PDT 2019


cmatthews accepted this revision.
cmatthews added a comment.
This revision is now accepted and ready to land.

Looks good.



================
Comment at: lnt/testing/__init__.py:52
         """
+        assert self.report_version <= 2
+
----------------
Could you add a comment or assertion text explaining why this check is needed.


================
Comment at: lnt/testing/__init__.py:211
+            info = dict()
+            info.update(self.info)
+            if self.report_version == 1:
----------------
info = dict(self.info)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65751/new/

https://reviews.llvm.org/D65751





More information about the llvm-commits mailing list