[PATCH] D66030: [libFuzzer] Merge: print feature coverage number as well.

Matt Morehouse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 10:22:20 PDT 2019


morehouse accepted this revision.
morehouse added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/fuzzer/FuzzerMerge.cpp:215
+    this->PrintStats(Where, "\n", 0, AllFeatures.size());
+  };
   Set<const TracePC::PCTableEntry *> AllPCs;
----------------
morehouse wrote:
> Should this use `UniqFeatures`?
Never mind, I see UniqFeatures is local to the loop.


================
Comment at: lib/fuzzer/FuzzerMerge.cpp:239
       if (AllFeatures.insert(Feature).second)
         UniqFeatures.insert(Feature);
     });
----------------
morehouse wrote:
> Hm.  Doesn't this mean `AllFeatures == UniqFeatures`?
Nope, this is in the loop.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66030/new/

https://reviews.llvm.org/D66030





More information about the llvm-commits mailing list