[PATCH] D66078: Added RAII object for authomatic restore of fp state

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 10:13:34 PDT 2019


kpn added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicInst.h:220
+      rmDynamic          ///< This corresponds to "fpround.dynamic".
     };
 
----------------
What does this change give us? Having rmDynamic == 0 means that if a bug causes it to be zero initialized we get the most conservative behavior from the compiler. What's the tradeoff? And where is this change tested?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66078/new/

https://reviews.llvm.org/D66078





More information about the llvm-commits mailing list