[PATCH] D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files.

[Digger via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:152
+  uint16_t Magic;
+  uint16_t SectionCount;
+  int32_t TimeStamp;
----------------
I think we should use the same name st NumberOfSections for same as in the XCOFFObjectFile.h ?


================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:155
+  uint32_t SymbolTableFileOffset;
+  int32_t SymbolTableEntryCount;
+  uint16_t AuxiliaryHeaderSize;
----------------
ditto, NumberOfSymTableEntries in the XCOFFObjectFile.h


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:186
+  for (auto *Sec : Sections)
+    Sec->reset();
+  Sections.clear();
----------------
the element of the sections is cleared, I do no think  we need to reset every element here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65159/new/

https://reviews.llvm.org/D65159