[PATCH] D66041: [TextAPI] Fix & Add tests for tbd files version 3.

Cyndy Ishida via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 09:26:06 PDT 2019


cishida added inline comments.


================
Comment at: llvm/unittests/TextAPI/TextStubV3Tests.cpp:133
+// Disable test for windows.
+#ifndef _WIN32
+TEST(TBDv3, WriteFile) {
----------------
ributzka wrote:
> I think this test should work now on windows,
Would removing that macro from all the text stub tests and running them be enough to verify it works on windows? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66041/new/

https://reviews.llvm.org/D66041





More information about the llvm-commits mailing list