[PATCH] D65530: [InstCombine] foldXorOfICmps(): don't give up on non-single-use ICmp's if all users are freely invertible

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 09:17:44 PDT 2019


lebedev.ri added a comment.

In D65530#1625321 <https://reviews.llvm.org/D65530#1625321>, @spatel wrote:

> Sorry for the delay in looking at this. What do the motivating examples look like for codegen? Are we getting the optimal codegen for these clamps, or would we better off trying to create min/max and/or saturating intrinsics?
>
> Make sure I didn't typo this translation, but I think I'm seeing extra instructions for vectors with this transform on x86 and aarch64:
>  ...


Sure, but that is irrelevant. D65765 <https://reviews.llvm.org/D65765> improves upon both of them:
https://godbolt.org/z/-UIddL


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65530/new/

https://reviews.llvm.org/D65530





More information about the llvm-commits mailing list