[PATCH] D64281: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 1]

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 09:04:29 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Aside from a comment change, this looks good to me. I'd wait for others to approve too though, and I wouldn't necessarily land it even then until some later patches are ready too, although I'm not sure about that.



================
Comment at: llvm/include/llvm/Object/MutableELFObject.h:45
+
+/// This class is used for doing mutations on an ELFObjectFile which only
+/// provides an interface for reading object files.
----------------
I'd change this slightly:

... an ELFObjectFile. The ELFObjectFile class only provides ...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64281/new/

https://reviews.llvm.org/D64281





More information about the llvm-commits mailing list