[PATCH] D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj

Mon Aug 12 08:48:44 PDT 2019

sfertile added inline comments.

================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:23
+enum {
+  NameSize = 8,
+  FileNamePadSize = 6
----------------
jasonliu wrote:
> sfertile wrote:
> > jasonliu wrote:
> > > sfertile wrote:
> > > > hubert.reinterpretcast wrote:
> > > > > Please commit the removal of `SectionNameSize` and `SymbolNameSize` separately from this patch. This conflicts with other Phabricator reviews in flight.
> > > > We should commit this as a NFC patch and then rebase this patch to reflect the change.
> > > I was planning to land this first. Then when dust settles(https://reviews.llvm.org/D65159), have a NFC patch to remove those enums. 
> > > In this way, we could have less dependencies. 
> > > The more pedantic way is of course to land that NFC before this patch and D65159, then rebase these two patches. 
> > > Have a slightly preference on my original plan because of less action on both end. 
> > > But if you think it's better to land that NFC first, let me know and I could do that. 
> > I do think its worthwhile to land the enum name change first and rebase the patches. I understand it introduces a bit of extra work but I think its worth the small bit of time it takes. 
> Sure. When the NFC patch is available, I will rebase this patch to reflect that. 
Committed in https://reviews.llvm.org/rL368584

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65240/new/

https://reviews.llvm.org/D65240