[PATCH] D66089: [llvm/Object] - Convert SectionRef::getName() to return Expected<>

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: include/llvm/Object/ELFObjectFile.h:468
+  if (Expected<section_iterator> SecOrErr = getSymbolSection(Sym)) {
+    consumeError(Name.takeError());
+    return (*SecOrErr)->getName();
----------------
What if the Expected is in the success state, but the StringRef is empty?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66089/new/

https://reviews.llvm.org/D66089