[PATCH] D66015: [llvm-strings] Improve testing of llvm-strings

[James Henderson via Phabricator via llvm-commits]

jhenderson marked an inline comment as done.
jhenderson added inline comments.


================
Comment at: test/tools/llvm-strings/file-filename.test:10
+CHECK:      [[FILE]]: abcd
+CHECK-NEXT: [[FILE]]: hijk
----------------
jhenderson wrote:
> grimar wrote:
> > My emotion for this test at first was: "what about multiple inputs?". Then I found
> > `multiple-inputs.test` test below. I would just inline it here.
> Okay.
Actually, multiple-inputs.test isn't just about the --print-file-name switch. It's more generally about how llvm-strings works with multiple inputs, i.e. it reads each of them in turn, and produces correct output with --print-filename and --radix when switching between files, so I think it belongs as a separate test.

Possibly I could be persuaded that the --print-file-name and --radix checks for multiple inputs belong in their respective tests, but I think multiple inputs still need testing separately.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66015/new/

https://reviews.llvm.org/D66015