[PATCH] D65191: [llvm-objdump] Implement highlighting

Seiya Nuta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 02:01:03 PDT 2019


seiya marked an inline comment as done.
seiya added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/X86/disassembly-highlighting.test:2
+## Show that when disassembling, llvm-objdump highlights symbol names,
+## registers, and immediate values by default.
+
----------------
jhenderson wrote:
> The comment says "by default", but the test doesn't show the default behaviour! It only shows behaviour when `--color` or `--color=false` is specified.
Good catch! I'll fix this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65191/new/

https://reviews.llvm.org/D65191





More information about the llvm-commits mailing list