[PATCH] D65884: [ARM] MVE Tail Predication

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

You had me convinced until the last line. I think it's probably simpler for the vctp to produce a v4i1, as we don't need the convert at all in this patch (unless I'm missing something).

Essentially, the vctp can either look more like the acle intrinsic (produce a i16, makes the acle->IR simpler, but the IR->instruction needs to match on a convert(vctp)), or more like the VCTP instruction (produce a v4i1, makes the IR->Instruction simpler). I would go with the second option, but Simon is the expert on all things Intrinsics. Go with whatever he thinks is OK!



================
Comment at: lib/Target/ARM/CMakeLists.txt:61
   Thumb2SizeReduction.cpp
+  Thumb2TailPredication.cpp
   )
----------------
I would go with MVETailPredicationPass.cpp


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65884/new/

https://reviews.llvm.org/D65884