[PATCH] D47927: [WIP][TargetLowering] Simplify expansion of S{ADD,SUB}O
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 8 13:21:10 PDT 2019
RKSimon added a comment.
one minor - @efriedma / @lebedev.ri anything to add?
================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:6494
+ ConditionRHS = DAG.getSetCC(dl, OType, RHS, Zero, ISD::SETGT);
+ }
+
----------------
Not sure if its necessary, but you could merge the comments and just have:
```
SDValue ConditionRHS = DAG.getSetCC(dl, OType, RHS, Zero, IsAdd ? ISD::SETLT : ISD::SETGT);
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D47927/new/
https://reviews.llvm.org/D47927
More information about the llvm-commits
mailing list