[PATCH] D65718: [LangRef] Document forward-progress requirement

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 9 20:35:57 PDT 2019


reames added a comment.

Just a note of caution: I see discussion starting on cornercases.  I would strongly suggest *not* blocking this patch on getting a fully consistent definition.  Having something documented which is "mostly right" is better than no documentation at all.  (Adding a explicit marker of subtleties under discussion is good.)  It's really tempting as reviewers to keep looking for the subtle problems, but remember, the confusion which keeps arising is over the basic need for a side effect, not the exact definition thereof!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65718/new/

https://reviews.llvm.org/D65718





More information about the llvm-commits mailing list