[PATCH] D64179: [CodeGen] Define an interface for the new pass manager.

Fri Aug 9 17:59:11 PDT 2019

fedor.sergeev added a comment.

In D64179#1610998 <https://reviews.llvm.org/D64179#1610998>, @czhang wrote:

> In D64179#1606205 <https://reviews.llvm.org/D64179#1606205>, @fedor.sergeev wrote:
>
> > I believe in order to make progress here we first need to settle down on a very principal matter -
> >
> >   what kind of IRUnit MachineFunction is?
>

Okey, everything you said there makes perfect sense. Thanks for clarification.

>> There are many details to dive in, but first lets work on doing the basics right:
>> 
>>   MachineFunctionPassManager
>>   FunctionToMachineFunctionPassAdaptor
> 
> This sentence doesn't quite parse for me. Could you please elaborate what you mean here? Which part of the basics specifically?

I mean both should work :)
In particular, MachineFunctionPassManager.
It seems that you just defined a typedef in a hope that it will work... for one you need some tests to verify that.
And my guess is that as soon as you instantiate MachineFunctionPassManager::run you will hit missing interfaces that generic PassManager template refers to.
At least I'm sure you will hit PassInstrumentation ones.

Lets first start with some basic unittests (see llvm/unittests/IR/PassManagerTest.cpp etc).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64179/new/

https://reviews.llvm.org/D64179